Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable client certificate test #3382

Merged

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

Remove the #[ignore] attribute on one of the client certificate tests. Due to a change in the underlying certificate verifier, the error rustls produces is slightly different to what it was previously, and this was causing the test to fail. We aren't interested in the specifics of the error message produced, we simply care that the error arose from the client certificate verification and not some bug in the test code. Having updated the test to check for the updated error, I've verified that it still fails for otherwise failing connections (e.g. the client not trusting the server certificate). Therefore I think a simple update to the test to reflect the new behaviour is sufficient here.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
570 0 3 570 100 1h33m56.103344s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jarhodes314 jarhodes314 added this pull request to the merge queue Feb 6, 2025
@reubenmiller reubenmiller changed the title re-enable client certificate test test: re-enable client certificate test Feb 6, 2025
Merged via the queue into thin-edge:main with commit 51ac34a Feb 6, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing Theme: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants